Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change rviz to no longer use opencv #1009

Merged
merged 2 commits into from
May 16, 2016
Merged

change rviz to no longer use opencv #1009

merged 2 commits into from
May 16, 2016

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented May 16, 2016

This would avoid issues with linking against OpenCV on Jessie which uses Qt4. It looks like the process may have already been done, but the dependencies were never removed?:

From https://github.com/ros-visualization/rviz/blob/kinetic-devel/src/rviz/default_plugin/depth_cloud_mld.cpp#L137-L139:

// The following computation of center_x,y and fx,fy duplicates
// code in the image_geometry package, but this avoids dependency
// on OpenCV, which simplifies releasing rviz.

@wjwwood
Copy link
Member Author

wjwwood commented May 16, 2016

@tfoote @vrabaud this resolves the Qt5/Qt4 issues with rviz on Jessie in my local VM. Turns out rviz doesn't use image_geometry any more and was unnecessarily linking against it...

See ros/rosdistro#11488 (comment)

@wjwwood wjwwood merged commit b1ad562 into kinetic-devel May 16, 2016
@wjwwood wjwwood deleted the no-opencv branch May 16, 2016 23:49
@tfoote
Copy link
Contributor

tfoote commented May 17, 2016

that's convenient!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants