Support 3D arrows and axes for visualizing PoseArrays. #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any thoughts? |
|
Don't want to seem impatient, but we frequently use this patch for inspecting pose arrays. Is there anything blocking a merge? |
|
+1 |
|
I would love to get this merged before bit rot sets in... |
|
@wjwwood Are you still the active maintainer of this repository? |
|
I am, but I'm in Korea at the moment. |
wjwwood
approved these changes
Oct 17, 2016
|
Just tried it out and it seems to work fine. Using it with the amcl pose cloud is pretty slow, but that's to be expected if you want the fancy 3D markers. |
130s
pushed a commit
to 130s/rviz
that referenced
this pull request
Aug 21, 2024
…/pr-1021 Remove warning in depth_cloud_mld.cpp (backport ros-visualization#1021)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for visualizing poses as 3D axes and arrows to the
PoseArrayDisplayplugin, same as thePoseDisplayplugin. The previous 2D arrows in a singleOgre::ManualObjectare still supported. That option will probably be more performant with very large numbers of poses.However, the 3D axes are the only option that visualize the full pose, so it is still useful to have those as an option. The 3D arrows are there for consistency with the
PoseDisplayplugin.Should fix #869