Mouse move #1433
Merged
Mouse move #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when mouseTracking is enabled for a QWidget it will get mouseMoveEvents even though no mouse button is pressed. This behaviour was faked in rviz with a 30Hz timer.
removal with noetic API/ABI break
|
Thanks a lot for this cleanup, which also fixes a nasty issue: If accidentally entering the RenderPanel with pressed mouse button, the camera was screwed... |
rhaschke
added a commit
to rhaschke/rviz
that referenced
this pull request
Sep 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #1175
enable mouse tracking for render_panel
when mouseTracking is enabled for a QWidget it will get mouseMoveEvents even though no mouse button is pressed. This behavior was faked in rviz with a 30Hz timer.
This is currently preserving API/ABI but could just as well be non preserving and go to noetic only. I did not observe any positive or negative impact from this change, just cleaner code (eventually).