fix yaml-cpp not found on macOS (catalina) #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the issue : ld: library not found for -lyaml-cpp clang: error: linker command failed with exit code 1 (use -v to see invocation)
rhaschke
requested changes
Nov 20, 2019
rhaschke
approved these changes
Nov 21, 2019
rhaschke
requested changes
Nov 21, 2019
src/rviz/CMakeLists.txt
Outdated
| @@ -144,7 +144,7 @@ target_link_libraries(${PROJECT_NAME} | |||
| ${TinyXML2_LIBRARIES} | |||
| ${X11_X11_LIB} | |||
| ${ASSIMP_LIBRARIES} | |||
| ${YAMLCPP_LIBRARIES} | |||
| ${yaml-cpp_LIBRARIES} | |||
There was a problem hiding this comment.
The variable is named YAML_CPP_LIBRARIES on Ubuntu 18.04. Is it different on Mac?
There was a problem hiding this comment.
My mistake. fixed !
|
Thanks a lot. |
rhaschke
pushed a commit
to rhaschke/rviz
that referenced
this pull request
Nov 21, 2019
... instead of pkg-config
rhaschke
pushed a commit
to rhaschke/rviz
that referenced
this pull request
Nov 21, 2019
... instead of pkg-config
rhaschke
pushed a commit
to rhaschke/rviz
that referenced
this pull request
Nov 21, 2019
... instead of pkg-config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue :
Description
pkg config succeeds in finding yaml but linker fails on macOS (tested on catalina)
Now on newer version of yamlcpp, the cmake config is installed.