Whenever open a dialog, the data stop update in 3D area and panels

[tsukione]

Maybe this is not an issue, just a qustion.
I found every time a open a Dialog, such as NewDisplay, NewPanels, the pointcloud and image stop updating.

I check the code, found every time before open a dialog, will call

rviz/src/rviz/visualization_frame.cpp

Line 642 in 7383000

manager_->stopUpdate();

When the dialog is closed, a startUpdate() wil called.

So, I just wondering why the stopUpdate() should be called. I comment the manager_->stopUpdate(); line, It still working perfectly, and the pointcloud and image is continuous changing, I'm happy with that :)

So, could you help me to get out from this question? thanks.

Environment

• OS Version: Ubuntu 18.04
• ROS Distro: Melodic
• RViz, Qt, OGRE, OpenGl version as printed by rviz:

[ INFO] [1617528442.570476806]: rviz version 1.13.16
[ INFO] [1617528442.570531904]: compiled against Qt version 5.9.5
[ INFO] [1617528442.570563003]: compiled against OGRE version 1.9.0 (Ghadamon)
[ INFO] [1617528442.574762879]: Forcing OpenGl version 0.
[ INFO] [1617528442.680312957]: Stereo is NOT SUPPORTED
[ INFO] [1617528442.680650647]: OpenGL device: llvmpipe (LLVM 10.0.0, 256 bits)
[ INFO] [1617528442.680780743]: OpenGl version: 3.1 (GLSL 1.4).

[rhaschke]

This protection was introduced in #631 on purpose. Did you try what happens if you overload the main rendering loop?

[tsukione]

This protection was introduced in #631 on purpose. Did you try what happens if you overload the main rendering loop?

Got it, I will test that later

[rhaschke]

Reverting #631 doesn't prevent message processing and display updating from pausing. This is due to the fact that all dialogs are modal, i.e. prevent Qt's event processing for other windows.

[tsukione]

I just tested it and commented out stopUpdate, and the data was still refreshing when the dialog was opened. So it has nothing to do with the modal window.

[rhaschke]

I test it as well (see this branch) and the display wasn't refreshing for me!? Could you provide your branch as well for testing?

[tsukione]

I pulled up the latest code(melodic-devel), and only commet this line:

rviz/src/rviz/visualization_manager.cpp

Line 306 in 3fa78da

update_timer_->stop();

[tsukione]

I have download your branch and tested, the point cloud data is still updating in the 3D area.

[rhaschke]

Hm. Don't know what happened before. But it works now for me as well. In principle, I'm fine to accept this behaviour for Noetic.

[rhaschke]

@tsukione, unfortunately, your feature request caused a regression: #1641.
I'm tempted to revert to the previous state.