[bugfix] Stop update while showing dialog boxes. Fixes #629 #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hershwg
added a commit
that referenced
this pull request
Apr 17, 2013
[bugfix] Stop update while showing dialog boxes. Fixes #629
Closed
rhaschke
added a commit
to rhaschke/rviz
that referenced
this pull request
Jun 17, 2021
VisualizationManager uses [start|stop]Update() to pause ROS updates during dialog box interaction (ros-visualization#631). However, asynchronous updates via threaded_queue_ were still performed, leading to a memory leak (ros-visualization#1621), because messages were partially processed by the thread (i.e. kept in memory), but not finally processed (and cleaned up) by the synchronous Display::update() call. Pausing threaded processing too resolves that issue.
rhaschke
added a commit
to rhaschke/rviz
that referenced
this pull request
Jun 18, 2021
Partially reverts ros-visualization#631. Fixes ros-visualization#1606.
rhaschke
added a commit
to rhaschke/rviz
that referenced
this pull request
Jun 18, 2021
Partially reverts ros-visualization#631. Fixes ros-visualization#1606.
rhaschke
added a commit
to rhaschke/rviz
that referenced
this pull request
Jun 19, 2021
Partially reverts ros-visualization#631. Fixes ros-visualization#1606.
rhaschke
added a commit
that referenced
this pull request
Jun 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem that rviz becomes effectively unusable when the update/render cycle takes too long (e.g. while showing high-frequency point cloud data).
All the dialogs will keep the main thread from calling any ROS callbacks, update functions or re-rendering the 3d view while they are active.
Also, removes outdated stuff from visualization manager.