Drop proprietary COLLADA scaling #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assimp provides the scale via the scene's root transform.
... but still ignore y-up rotation introduced by assimp.
R^{-1}.T yields the scaling matrix. I don't see a reason to apply scaling
and then revert it via Normalize().
7 tasks
|
Thanks for the more proper fix. I confirm it solves the problem for me: unpatched rviz with patched rviz with |
simonschmeisser
approved these changes
Nov 27, 2021
|
@rhaschke friendly ping |
This was referenced Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out by @simonschmeisser in #1684 (comment),
assimpshould actually provide the correct scaling factor and it actually does: The scaling is embedded in the root node's transform, which was deliberately ignored.Fixes #1665. @simonschmeisser and @peci1, could you please review and test?