Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation with Qt4 #1370

Closed
wants to merge 1 commit into from
Closed

Fix compilation with Qt4 #1370

wants to merge 1 commit into from

Conversation

VictorLamoine
Copy link
Contributor

Fixes #1369

This removes text eliding in dock widgets because the FindDirectChildrenOnly flag is only available starting from Qt 5

@theobslhc can you test compilation with Qt4?

@theobslhc
Copy link

theobslhc commented Apr 24, 2019

@VictorLamoine thank you !
Compilation works fine with Qt4.
No problem at runtime with the configuration file linked to in PR #1168.

@rhaschke
Copy link
Contributor

This solution essentially reverts #1168 for Qt4. To make the change less intrusive, I suggest to mask out only the content of onDockPanelChange but keep all other code as is. This will also maintain ABI and API compatibility.
Even better, you should mimic FindDirectChildrenOnly by checking child->parent == this ;-)

@theobslhc
Copy link

Thanks @rhaschke for the suggestion. Here's another PR : #1371

@VictorLamoine VictorLamoine deleted the kinetic-devel-elide-qt4 branch April 25, 2019 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants