Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation with Qt4 (#1369) #1371

Merged
merged 2 commits into from
Apr 25, 2019
Merged

Fix compilation with Qt4 (#1369) #1371

merged 2 commits into from
Apr 25, 2019

Conversation

theobslhc
Copy link

@theobslhc theobslhc commented Apr 25, 2019 •
edited
Loading

Fixes #1369.

This fix does not revert dock text eliding disabling as introduced in #1168 for Qt4.
Tested with Qt4 v4.8.7.

rhaschke
rhaschke requested changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already better than #1370. However, you should keep Qt::FindDirectChildrenOnly for Qt5 as this is much more efficient than first retrieving the whole list and subsequently pruning it again.

@theobslhc theobslhc mentioned this pull request Apr 25, 2019
Closed
@rhaschke rhaschke merged commit 9b8f2a8 into ros-visualization:kinetic-devel Apr 25, 2019
@theobslhc theobslhc deleted the kinetic-devel-elide-qt4-fix branch April 25, 2019 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhaschke rhaschke rhaschke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theobslhc @rhaschke