Fix problem with Googletest's LIBRARY_OUTPUT_DIRECTORY

[roehling]

The horribly maintained CMake files which are shipped with Googletest
override the library output directory to ${CMAKE_BINARY_DIR}/lib, which
points to the top-level build directory (it should have been
CMAKE_CURRENT_BINARY_DIR).

Unfortunately, that directory is used by setuptools as staging area for
Python modules, and setup.py install will happily install everything it
finds in the lib/ folder, including the libgtest.so binary. Among
others, this has bitten PR2/pr2_mechanism#343 and ros/geometry#223

This PR fixes the output location to something sane(ish).

[v4hn]

Thanks for looking into this Timo! You're proving the point that talking to colleagues about an issue at times resolves the issue 😄 💐

[jspricke]

Thanks! Please rebuild ros-noetic-controller-manager-tests, ros-noetic-pr2-controller-manager, ros-noetic-tf after releasing this.
Found using: ros/pool/main/r$ for f in ros-noetic-*/*.deb; do dpkg-deb -c "$f" | grep -q "python3/dist-packages/libgtest.so" && echo "$f"; done

[davefeilseifer]

was this rebuild done? it seems the most recent noetic sync did not fix this problem. Installing both ros-noetic-pr2-mechanism is still showing a conflict

[roehling]

@davefeilseifer I doubt it, the PR is still unmerged.

[davefeilseifer]

this is holding up prerelease testing for several other pr2 packages, is there anything that can be done to hurry this along?

[v4hn]

ping @mjcarroll @dirk-thomas

[dirk-thomas]

ping

@v4hn I am not a maintainer of this repository anymore.

[peci1]

@tfoote @mjcarroll This has been holding the whole Moveit and dependent packages from Noetic release for more than a month...

[fmauch]

Any chance this would get applied to melodic, as well? We've also stumbled upon this in our ros-melodic package builds on Archlinux (see ros-melodic-arch/ros-melodic-tf#6)