Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS2: Parameter description hotfix #121

Closed
wants to merge 2 commits into from
Closed

ROS2: Parameter description hotfix #121

wants to merge 2 commits into from

Conversation

klintan
Copy link

@klintan klintan commented Aug 25, 2019

Couldn't compile in dashing because declare_parameter needed 3 arguments, haven't seen that before, but it seems the parameter_interface does not have a default value for ParameterDescription.

edit: fails because it runs on crystal, some of these changes are dashing-specific.

@klintan
Copy link
Author

klintan commented Aug 25, 2019

Running tests locally everything is fine except for the parameter: name = 'diagnostic_updater.period'
even though it's not a topic it complains it's not a valid topic name. Should we change the parameter name to diagnostics_updated_period ?

@Karsten1987
Copy link
Contributor

The default value got backported to dashing in here ros2/rclcpp#794

Are you sure you are working with the latest dashing release? You might have to upgrade your system (sudo apt-get upgrade) or try working with the latest testing release repos: https://wiki.ros.org/TestingRepository

Looking at the PR introducing the parameter, the build worked successfully on all platforms with dashing: #112

I am going to close this as I believe using the latest dashing debs might solve your problem. Feel free to re-open this ticket if your problems persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants