support for node interfaces #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karsten1987
force-pushed
the
node_interfaces
branch
from
dfcdc37 to
4bc5c4e
Compare
Merged
cottsay
requested changes
Jun 26, 2019
diagnostic_updater/include/diagnostic_updater/diagnostic_updater.hpp
Outdated
Show resolved
Hide resolved
Karsten1987
force-pushed
the
node_interfaces
branch
from
d6a88d5 to
6f91c8c
Compare
|
@cottsay I've rebased and addressed hopefully all your comments. Do you mind glancing one more time over this PR? |
cottsay
reviewed
Aug 5, 2019
cottsay
reviewed
Aug 5, 2019
diagnostic_updater/include/diagnostic_updater/diagnostic_updater.hpp
Outdated
Show resolved
Hide resolved
|
This is up for one more round of review :) |
cottsay
approved these changes
Aug 23, 2019
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Karsten1987
force-pushed
the
node_interfaces
branch
from
691770c to
9eb7501
Compare
|
This was referenced Aug 26, 2019
Karsten1987
added a commit
to boschresearch/ros2_diagnostics
that referenced
this pull request
Aug 27, 2019
* support for node interfaces Signed-off-by: Karsten Knese <karsten@openrobotics.org> * use default parameter descriptor Signed-off-by: Karsten Knese <karsten@openrobotics.org> * rclpy 373 resolved: use namespace for parameter Signed-off-by: Karsten Knese <karsten@openrobotics.org> * set qos profile for publisher Signed-off-by: Karsten Knese <karsten@openrobotics.org> * make c++ and py example behave similar Signed-off-by: Karsten Knese <karsten@openrobotics.org> * set period as either rcl_duration_value_t or double Signed-off-by: Karsten Knese <karsten@openrobotics.org> * revert changes to leading slashes in favor of pr 109 Signed-off-by: Karsten Knese <karsten@openrobotics.org> * accept also raw pointer to node Signed-off-by: Karsten Knese <karsten@openrobotics.org> * make tests compile Signed-off-by: Karsten Knese <karsten@openrobotics.org> * make parameter names equal between c++ and py Signed-off-by: Karsten Knese <karsten@openrobotics.org> * prefix parameter with diagnostic_updater Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #111
This PR does a few touch ups for the latest dashing release as well as introducing support for other nodes such as lifecycle nodes.
Signed-off-by: Karsten Knese karsten@openrobotics.org