Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Handling unloading of diagnostics by service #53

Closed

Conversation

stonier
Copy link

@stonier stonier commented Sep 19, 2016

First iteration on attempting to solve the problem highlighted by #50.

  • Stores the bond, analyzer into a vector of pairs (previously just the bond)
  • Toggles loaded<->unloaded whenever a service call to add_diagnostics is made depending on if it is not yet loaded or already loaded.

Kind of aiming for a minimum delta here. I would say tackling this more properly should require the addition of a separate remove_diagnostics service with its own type (or at least a dual-purpose name for the diagnostics_msgs/AddDiagnostics srv).

If this is required, I can push this PR in that direction.

Just a reminder for us, will also need a cherry-pick across to the master branch.

@AlexReimann
Copy link

Still working on this?

@amilcarlucas
Copy link

This needs a rebase

@AlexReimann
Copy link

Fyi: Myself doesn't plan to be working on this anymore

@g-gemignani
Copy link
Collaborator

Closing due to inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants