[WIP] Handling unloading of diagnostics by service #53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First iteration on attempting to solve the problem highlighted by #50.
add_diagnostics
is made depending on if it is not yet loaded or already loaded.Kind of aiming for a minimum delta here. I would say tackling this more properly should require the addition of a separate
remove_diagnostics
service with its own type (or at least a dual-purpose name for thediagnostics_msgs/AddDiagnostics
srv).If this is required, I can push this PR in that direction.
Just a reminder for us, will also need a cherry-pick across to the master branch.