Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed race condition in MessageFilter by removing the callback #384

Closed
wants to merge 1 commit into from
Closed

Fixed race condition in MessageFilter by removing the callback #384

wants to merge 1 commit into from

Conversation

StefanFabian
Copy link

This pull request fixes issue #379 by simply removing the callbacks in the destructor.

It is an alternative to #383.
Cons:

  • Might not always fix the issue in multithreaded environments depending on the implementation/thread-safety of the CallbackQueue

Pros:

  • simple and no overhead

@StefanFabian StefanFabian mentioned this pull request May 22, 2019
Closed
@tfoote tfoote self-requested a review May 24, 2019 22:56
rhaschke
rhaschke reviewed Aug 17, 2019
View reviewed changes
Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as #402. Can be closed here.

@rhaschke rhaschke mentioned this pull request Aug 17, 2019
Merged
@StefanFabian
Copy link
Author

Thank you!
That's also my preferred solution even though it relies on the callback queue being threadsafe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhaschke rhaschke rhaschke left review comments

@tfoote tfoote Awaiting requested review from tfoote tfoote is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StefanFabian @rhaschke