Fix message filter #402
Merged
Fix message filter #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 13, 2019
tfoote
approved these changes
Aug 16, 2019
This was referenced Aug 17, 2019
|
Friedly ping: #402 (comment) |
rhaschke
added a commit
to rhaschke/rviz
that referenced
this pull request
Apr 16, 2020
This reverts commit 5ab445b. This reverts commit 42eed97. This reverts commit 371b23a partially. As ros/geometry2#402 is released since tf2 >= 0.6.6, we can revert these hot fixes.
rhaschke
added a commit
to rhaschke/rviz
that referenced
this pull request
Jun 18, 2021
... since ros/geometry2#402 is released
rhaschke
added a commit
to rhaschke/rviz
that referenced
this pull request
Sep 24, 2021
We need to wait for TF2 0.6.7 to be actually released. This reverts commit 25d2c81.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a segfault of
MessageFilterpointed out in ros-visualization/rviz#1372 and analyzed in detail in ros-visualization/rviz#1393.Essentially, when destroying/clearing the filter, all pending callbacks (which store a pointer to the filter itself) should be removed. Otherwise, when called, these callbacks will access the destroyed filter pointer.
Additionally, in a destructor, only fully-qualified virtual functions may be called.