Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 1441 #1442

Merged
merged 1 commit into from
Aug 3, 2018
Merged

Fix for issue 1441 #1442

merged 1 commit into from
Aug 3, 2018

Conversation

pbaughman
Copy link

Suggested fix for #1441

Use the logger.Handler's format method so that by default stack traces
are included in the log message if exc_info is set on the LogRecord

Use the logger.Handler's format method so that by default stack traces
are included in the log message if exc_info is set on the LogRecord
@tfoote
Copy link
Member

tfoote commented Jun 22, 2018

Hmm there was a rosbag error off by one on stretch only that seems like it should be unreleated.

1967 != 1968
  File "/usr/lib/python2.7/unittest/case.py", line 329, in run
    testMethod()
  File "/tmp/catkin_workspace/src/ros_comm/test/test_rosbag/bag_migration_tests/test/random_play.py", line 113, in test_random_play
    self.assertEqual(len(self.input), rmg.message_count())
  File "/usr/lib/python2.7/unittest/case.py", line 513, in assertEqual
    assertion_func(first, second, msg=msg)
  File "/usr/lib/python2.7/unittest/case.py", line 506, in _baseAssertEqual
    raise self.failureException(msg)

@ros-pull-request-builder retest this please.

@tfoote
Copy link
Member

tfoote commented Jun 27, 2018

The CI passed on a retest.

@dirk-thomas
Copy link
Member

Thank you for the improvement.

@dirk-thomas dirk-thomas merged commit cbec901 into ros:melodic-devel Aug 3, 2018
@pbaughman pbaughman deleted the issue_1441_rosout_formatting branch August 3, 2018 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants