changes between 1.14.3 and 1.13.6 for backporting #1477
Conversation
* Template std::max instead of casting explicitly.
* Handle RLIM_INFINITY * XmlRpcServer: use unsigned int for rlimit * Properly link xmlrpcpp tests * Exclude test libraries from all target * Symbol overriding for OSX * fix signed / unsigned comparison warning
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
* Make a copy of the topic list get_topics() returns a set, which is iterated by the Log constructor. Make a copy of the set (atomic in cpython!) so nobody adds or removes something while the Log constructor iterates over it * Revert "Make a copy of the topic list", Fix This reverts commit 0e019e0. Move the fix to the _TopicManager so anybody else calling get_topics doesn't get burned by the same issue as _rosout
…1450) * Rename getLastestTime to getLatestTime Per directions [here](#1449 (comment)). * Test getLatestTime instead of getLastestTime per #1449 (comment)
|
Looks like good picks to me. |
|
I would like to request #1464 to be added to the backported list. I wouldn't really call it a new feature, it is only a minor getter that allows to avoid hacking around this issue in user code. This is especially desired as Kinetic is likely to stay around for a while within companies using ROS: many haven't even left Indigo yet, let alone planning to move to Melodic. |
This on it's own is not a real argument because at the same time these users demand stability. That is ultimately the reason why we have distributions and changes to existing distros are limitted to bug fixes (since any change has the potential to introduce regressions).
That being said I agree with you that #1464 is a very small API addition which should be safe to backport to provide the convenience not to pass the information in parallel. 👍 I cherry-picked the corresponding commit in d80aa6d and updated the above description. |
The following list of changes has been integrated into
ros_comm1.14.3 (Melodic) since the last Lunar release (1.13.6).Commits before branching: some commits were made after the 1.13.6 release before the branch for Melodic was created. Those are therefore the same on the Lunar and Melodic branch. They won't be enumerated here.
Backported: (these changes are part of this PR)
rosbag record: Add TransportHint options --tcpnodelay and --udp (rosbag record: Add TransportHint options --tcpnodelay and --udp #1295)
topic_tools: Check that output topic is valid in demux (topic_tools: Check that output topic is valid in demux. Fixes #1366 #1367)
Replaced Double-Checked Locking pattern with static variable (Replaced Double-Checked Locking pattern with static variable. Fixes #1364 #1365)
Fix "pass_all_args" for roslaunch-check, add nosetest (fix "pass_all_args" for roslaunch-check #1368)
Convert the period standard deviation in StatisticsLogger to Duration at the end. (Rework the period standard deviation calculation in Sta… #1361)
Fix integer overflow for oneshot timers. (Fix integer overflow for oneshot timers. #1382)
Change to force a rebuild of the pollset on flag changes (Change to force a rebuild of the pollset on flag changes #1393)
XmlRpcpp fixes for OSX (XmlRpcpp fixes for OSX #1402)
Fix the count of subscribers. (Fix the count of subscribers. #1407)
Fix Issue 1346 - Make a copy of the topic list (Fix Issue 1346 - Make a copy of the topic list #1416)
Fix some errors in some probably not frequented code paths (Fix some errors in some probably not frequented code paths melodic #1415)
Rename python message_filters.Cache.getLastestTime to getLatestTime (Rename python message_filters.Cache.getLastestTime to getLatestTime #1450)
Add hasStarted()const to Timer API (Add hasStarted() const to Timer API #1464)
Not backported:
added parameter to stop client libraries from generating topics list (added parameter to stop client libraries from generating topics list #1241)
Adds latch functionality (Adds latch functionality #1341)
Use boost::shared_ptr to fix memory leak in BagPlayer (Use boost::shared_ptr to fix memory leak in BagPlayer #1373)
Use HTTP/1.1 in XMLRPC Server (Use HTTP/1.1 in XMLRPC Server #1287)
fix sphinx warning (fix sphinx warning #1371)
roslaunch: add --log option (roslaunch: add --log option #1330)
add time when timer expired to timer events (add time when timer expired to timer events #1130)
Implement Bag encryption/decryption (Implement Bag encryption/decryption. #1206)
Keep connection header info in rosbag filter/compress (keep connection header information in rosbag operations (#679, #685) #1372)
Fix compiler warning of test_aes_encryptor (Fix compiler warning of test_aes_encryptor #1376)
Specialize BagCallbackT for MessageInstance (Specialize BagCallbackT for MessageInstance #1374)
warn if ROS_IP contains whitespace (warn if ROS_IP contains whitespace #1379)
Changed invocation to
addto conform template syntax (Changed invocation toaddto conform template syntax #1388)topic_tools: throttling when rostime jump backward (topic_tools: throttling when rostime jump backward #1397)
Allow disabling rosout file logging (to rosout.log) (Allow disabling rosout file logging (to rosout.log) #1381)
suppress sequential identical messages (suppress sequential identical messages #1309)
remove rosconsole (remove rosconsole #1405)
Add in -D_FILE_OFFSET_BITS=64 on machines less than 64-bits. (Add in -D_FILE_OFFSET_BITS=64 on machines less than 64-bits. #1406)
import rosbag locally instead of at module level (import rosbag locally instead of at module level #1424)
fix compiler warnings about unused variables (fix compiler warnings about unused variables #1428)
Throw BagException when disk is full (Throw BagException when disk is full #1451)
Fix for issue 1441 (Fix for issue 1441 #1442)
message_filters: call Subscriber::unsubscribe() in destructor (message_filters: call Subscriber::unsubscribe() in destructor #1434)
fix regressions from 1372 (fix regressions from 1372 #1473)
@ros/ros_team @ros/ros_comm-maintainers RFC.