Use HTTP/1.1 in XMLRPC Server #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the patch. This looks really promising! It works for me in the case described in the referenced earlier PR. @mikepurvis Could you give this patch a try by using it in your deployment for some days? |
dirk-thomas
approved these changes
Feb 1, 2018
|
Looks great, thanks! |
|
Oh shoot, wrong target branch. |
mikepurvis
added a commit
that referenced
this pull request
Apr 23, 2018
This reverts commit 5e2b38e. This change may be considered for backporting to Lunar at a later time.
mikepurvis
pushed a commit
that referenced
this pull request
Apr 23, 2018
|
Reverted from Lunar, cherry-picked to Melodic as per the linked commits above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR activates HTTP/1.1 in the XMLRPC Server and fixes the CTRL-C issues that were reported in #371
Setting daemon_threads to True allows the program to terminate.