Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix regressions from 1372 #1473

Merged
merged 4 commits into from
Aug 6, 2018
Merged

fix regressions from 1372 #1473

merged 4 commits into from
Aug 6, 2018

Commits on Aug 3, 2018

  1. make new argument optional to restore API compatibility

    @dirk-thomas
    dirk-thomas committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    d97e9f1 View commit details
    Browse the repository at this point in the history

  2. Fix rosbag's internal _read_message API

    @lalten @dirk-thomas
    lalten authored and dirk-thomas committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    bb2c107 View commit details
    Browse the repository at this point in the history

  3. Correct return_connection_header's default value from None to False

    @lalten @dirk-thomas
    lalten authored and dirk-thomas committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    3d70fae View commit details
    Browse the repository at this point in the history

  4. Add return_connection_header=False arg 

    ... to seek_and_read_message_data_record, for BagReady102.

Otherwise we get this error (e.g. using rqt_bag):
  File ".../lib/python2.7/dist-packages/rosbag/bag.py", line 1299, in _read_message
    return self._reader.seek_and_read_message_data_record(position, raw)
    TypeError: seek_and_read_message_data_record() takes exactly 4 arguments (3 given)
    @efernandez @dirk-thomas
    efernandez authored and dirk-thomas committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    bdd77e2 View commit details
    Browse the repository at this point in the history