[Kinetic] Backport #2038 #2058
Closed
[Kinetic] Backport #2038 #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add SIGTERM and SIGINT handlers to rosbag record Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Add unit test for rosbag record SIGINT handling Add unit test for rosbag record SIGTERM handling Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Address review comments Fix sending SIGINT to main process Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Revert added whitespace Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Revert SIGINT handler addition: use default Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Remove unnecessary wait Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Use BSD License Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Add test improvements Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Move test helper function Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Remove redundant test rosbag launch Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Add Amazon to new python test copyright Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Remove unrelated whitespace Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Split record cleanup unit tests Add record cleanup unit test helper Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Revert whitespace change Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * revert white space change Co-authored-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
|
@dirk-thomas please review |
|
Changes are backported together before a new patch release and not on an individual base since with the number of changes and their order that becomes unmanagable. See #1496 which describes the process. In this case the change first needs to land in a Noetic release, then be backported to Melodic and from there to Kinetic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #2038 , resolves #2006