Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kinetic] Backport #2038 #2058

Commits on Sep 23, 2020

  1. Gracefully stop recording upon SIGTERM and SIGINT (ros#2038)

    * Add SIGTERM and SIGINT handlers to rosbag record
    
    Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
    
    * Add unit test for rosbag record SIGINT handling
    Add unit test for rosbag record SIGTERM handling
    
    Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
    
    * Address review comments
    Fix sending SIGINT to main process
    
    Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
    
    * Revert added whitespace
    
    Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
    
    * Revert SIGINT handler addition: use default
    
    Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
    
    * Remove unnecessary wait
    
    Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
    
    * Use BSD License
    
    Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
    
    * Add test improvements
    
    Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
    
    * Move test helper function
    
    Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
    
    * Remove redundant test rosbag launch
    
    Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
    
    * Add Amazon to new python test copyright
    
    Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
    
    * Remove unrelated whitespace
    
    Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
    
    * Split record cleanup unit tests
    Add record cleanup unit test helper
    
    Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
    
    * Revert whitespace change
    
    Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
    
    * revert white space change
    
    Co-authored-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
    dabonnie and dirk-thomas committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    26d5e3e View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2020

  1. add rostopic test dependency

    Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
    dabonnie committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    515880e View commit details
    Browse the repository at this point in the history