Changes between 1.14.9 and 1.14.10 for backporting to Kinetic #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added skip_cache parameter to rosnode_ping() to give programmers the possibility to skip looking into the cache of nodes and instead force looking them up from master * Fixed indentation and added keyword argument
* rosnode_cleanup() now also removes unavailable nodes from the local node cache _caller_apis. This prevents buggy behaviour when nodes become unvailable because they exit the ros network due to wifi issues but then reconnect to it later on. * Fixed indentation
If one ROS node is setting and at the same time subscribing to the same parameter the ROS master does not notify about a parameter change. This change makes sure that the cache is updated after a set_param call.
This fixes a bug in ROSOutAppender that consists of waiting on the condition_variable `queue_condition_` without checking if the `log_queue_` is empty. In this situation if the `log_queue_` had some messages that were inserted while `ROSOutAppender::logThread` was publishing other messages, the new messages in the queue won't be published, until another message eventually is added. Note that the `notify_all` sent in the destructor would not cause the unpublished messages to get published, as when the `queue_condition_` is awaken by this notification, `shutting_down_` would be true and would cause `ROSOutAppender::logThread` to return immediately. Co-authored-by: Adel Fakih <adel.fakih@avidbots.com>
As far as I can tell, not being able to ping itself does not *cause* the issue (at least if ping refers to using the `ping` program to check if a host can be reached). Not sure if this wording is the optimal.
* Fix log*_throttle with sim time When log*_throttle is used with bags or a simulation, logging stops. Solved this problem with resetting logging_time_table when ros time moved backward * fixed a bug where client loses a log message when rostime goes backward removed paranthesis fixed a bug where client loses a log message when rostime goes backward
* Add SIGTERM and SIGINT handlers to rosbag record Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Add unit test for rosbag record SIGINT handling Add unit test for rosbag record SIGTERM handling Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Address review comments Fix sending SIGINT to main process Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Revert added whitespace Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Revert SIGINT handler addition: use default Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Remove unnecessary wait Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Use BSD License Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Add test improvements Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Move test helper function Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Remove redundant test rosbag launch Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Add Amazon to new python test copyright Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Remove unrelated whitespace Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Split record cleanup unit tests Add record cleanup unit test helper Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Revert whitespace change Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * revert white space change Co-authored-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
* Trap for overly large input to XmlRPCPP which could cause problems with int <-> size_t conversions. - In XmlRpcClient, XmlRpcServerConnection and XmlRpcSocket, recognize when incoming or outgoing data is too large, generate an error and discard the data when practical. - Use the safe strtol() rather than atoi() to decode an incoming content-length header, and generate an error if the length is invalid or too large. - In XmlRpcUtil, prevent attempts to parse overly large XML input. - Add tests where they can reasonably be inserted into existing test routines. Although this fix could be cleaner the update is written to make the update ABI compatible. This fix addresses CVE-2020-16124 / Integer overflow in ros_comm. Signed-off-by: Sid Faber <sid.faber@canonical.com> * Trap for memory allocation error in tests Signed-off-by: Sid Faber <sid.faber@canonical.com> * Revert earlier change Signed-off-by: Sid Faber <sid.faber@canonical.com> * Update tests Replace call to GTEST_SKIP with output to stderr. Remove the redResponseOversize test since out-of-memory errors during testing cannot easily be handled within the existing test objects. Signed-off-by: Sid Faber <sid.faber@canonical.com> * Improve test error handling Use GTEST_SKIP if available, otherwise print to stderr. Remove test that's being killed because it takes too long to handle the oversize test values
* add unsubscribeCachedParam. Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com> * unsubscribe all the cached parameters. Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com> * add const S_string::iterator. Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com> * delete unnecessary if statement. Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com> * unsubscribeCachedParam should be called when parameter is deleted. Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com> * fix parenthesis location. Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
Previous: @dirk-thomas New: @jacobperron, @mjcarroll, @sloretz Signed-off-by: Shane Loretz<sloretz@openrobotics.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
* set call_finished_ with true for each call inside callFinished and also set current_call flags when failure happens Signed-off-by: Chen Lihui <lihui.chen@sony.com> * Update based on review Co-authored-by: Tomoya.Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com> * set the flag with true again even if it is true already Signed-off-by: Chen Lihui <lihui.chen@sony.com> Co-authored-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
mjcarroll
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following list of changes has been integrated into ros_comm between 1.14.9 and 1.14.10 since the last Kinetic release (1.12.16).
Backported (in this PR):
Add skip_cache parameter to rosnode_ping() (Add skip_cache parameter to rosnode_ping() #2009)
Remove unavailable nodes from local node cache _caller_apis (Remove unavailable nodes from local node cache _caller_apis #2010)
Update local parameter cache on set_param ([rospy] fix param cache when node is subscribing and setting a parameter #2021)
Fix Lost Wake Bug in ROSOutAppender (Fix Lost Wake Bug in ROSOutAppender #2033)
Change error message (Change error message #2035)
Fix log*_throttle with sim time (Fix log*_throttle with sim time #2044)
Gracefully stop recording upon SIGTERM and SIGINT (Gracefully stop recording upon SIGTERM and SIGINT #2038)
Trap for overly large input to XmlRPCPP (Trap for overly large input to XmlRPCPP #2065)
Cached parameter should be unsubscribed (cached parameter should be unsubscribed #2068)
Update maintainers ([Noetic] Update maintainers #2075)
Fix paramtest for empty values of a parameter (Fix paramtest for empty values of a parameter #2054)
Set call_finished_ with true for each call inside callFinished (set call_finished_ with true for each call inside callFinished #2074)
Not backported:
Fix issue with rospy.set_param('') (Fix issue with rospy.set_param('') #2024)
XmlRpcValue::_doubleFormat should be used during write (XmlRpcValue::_doubleFormat should be used during write. #2003)
Fix spelling (fix misspell. #2066)
Install advertisetest (advertisetest ist not installed #2045)
[Windows] Single quote string fix-up ([Windows] Single quote string fix-up #2051)