Fix for #854 - cleaner rosout log rotation #855
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make LogAppender destructor virtual
add missing parameter to AdvertiseOptions::createAdvertiseOptions
change return value of param() to bool
improve TopicManager::instance
…the case on the farm)
Requires ros/genpy#52 to be merged/released first
Add missing inter-test dependency
Use defusedxml in rosmaster
use directory specific compiler flags
The previous code was not properly filtering unicode/str out of the header. Added the corresponding unit test.
fix passing multiple args to add_rostest
fix header encoding in encode_ros_handshake_header
- evaluation of expressions of the form $(eval ...)
- functions env(), optenv(), anon(), find(), arg() map onto corresponding $-substitutions
- implicit access to args using their name, i.e. name instead of arg('name')
python evaluation of expressions in roslaunch
... and added appropriate unittests
added math symbols and some standard data types for python evaluation
Example usage: void callback(const boost::shared_ptr<M const>&) message_filters::Subscriber<std_msgs::UInt32> sub(nh, "my_topic", 1); sub.registerCallback(myCallback); cf. http://wiki.ros.org/message_filters#Example_.28C.2B-.2B-.29
* Fix rostopic echo for non rosmsg field Close ros#908 * Show stat for echoing non ROS message * Fix field stat information with --nostr for string[] * Add function of field value transformation
Don't rely on transitive header inclusion to declare std::vector as building with GCC-6 fails due to no '#Include <vector>' statement.
Add '#Include <vector>' to fix building on GCC-6
Handles issues with many simultaneous connections to XmlRPC Server in OSX 10.11
Use boost::bind to bind the callback function
add USE_TEST_DEPENDENCIES option to roslaunch_add_file_check()
[rostopic] Fix typo of arg for _str_plot function
Remove duplicated function, use decorator
add missing walltime to roscpp logging
Take the ._type using [0], because the arguments passed to migrate_raw are tuples. This was throwing another exception because of that bug: AttributeError, saying that tuple has no attribute _type.
while roscpp reconnects on timeout or temporary 'No route to host' errors the rospy does it not. So on connection problems longer than 3 min the connection between subscriber and publisher goes. I added some exceptions if these occurs rospy does not close the socket and reconnect now. rospy: limited exponential backoff since rospy reconnects on timeout now, the reconnects goes very fast in times where it easier to restart the ros node then wait for a reconnect. So I added a maximal backoff time. rospy: added reconnection for topic connect while node start on connection problems while node start the subscription to a publisher will be stopped after 3 tries. Now the reconnection is stopped on shutdown of the node.
Fix BagMigrationException in migrate_raw
Fix WallTimerEvent class -> struct
Drop epydoc from rosbag_storage
* [rospy] made get_published_topics threadsafe
|
Splitting this into two PR: one for Kinetic e.g. moving init code, one for Lunar only with changing order. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #854 by rotating the log files as usual in Linux to guarantee the ordering of log files (https://en.wikipedia.org/wiki/Log_rotation).