Add bson

[awesomebytes]

bson is a dependency for rosbridge_library, needed for Gentoo (as seen in ros/ros-overlay#560).

xdot is a run depend of ecto.

[tfoote]

There's already a key python-xdot

rosdistro/rosdep/python.yaml

Line 3922 in c075a34

python-xdot:

that should be extended/reused instead of creating a new one.

[mikaelarguedas]

After a bit of archaeology:
This key has been renamed from xdot to python-xdot in #15259. This is mostly because rosdep doesnt support/allow collisions between released ros package names and rosdep keys (ros-infrastructure/rosdep#539). But we didn't want to keep releasing xdot as a ROS package now that it's available upstream.

At the time of the renaming, issues have been opened on the repos using it to notify of the change:
srv/srv_tools#16
plasmodic/ecto#297
But the packages don;t seem to have been updated since.

If you want to compile these packages from source you will need to rename the key in their package.xml. If you can submit PRs on these repos with the change that would be valuable as well 😄

The bson change can stay in this PR though 👍 but the xdot rule should be removed.

Thanks!

[awesomebytes]

@mikaelarguedas Done, removed the commit about xdot. Sorry for the noise! I didn't find that information at the moment. Interesting. I'll need to patch that for the Gentoo packages building.

[mikaelarguedas]

lgtm, thanks @awesomebytes

[awesomebytes]

@tfoote All good now?

[tfoote]

@awesomebytes Please actually submit the patch upstream so that the code uses the correct rosdep keys. It will be needed in the next release anyway and it will be better to have it upstream instead of just in gentoo.

[awesomebytes]

@tfoote Done:

• srv_tools: Fix rosdep key srv/srv_tools#21
• ecto: Update rosdep key plasmodic/ecto#299