Add bson as it's needed as rosdep key #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in python-bson in rosdistro. And gentoo doesn't have it packaged.
|
lgtm -- thanks! |
|
Thanks for merging, rosdistro PR is done also. |
|
@allenh1 can you regenerate stuff? the PR has been merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in python-bson in rosdistro. And gentoo doesn't have it packaged.
To generate this I did:
Copy the structure of rosdep, which already pulls from PyPI. Modified the ebuild to match the package and it's dependencies by downloading the actual PyPI package .tar.gz and checking setup.py.
Checked in https://packages.gentoo.org/ if the packages existed, which they did, so I just wrote the dev-
python/pytz.Then I needed to generate a Manifest file, so googling I found this useful link and just followed that command.
Pending is to ask for the addition of this in rosdistro (which I'll do right away).