Add rosdep rules for python3-bson #22333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
allenh1
suggested changes
Sep 24, 2019
There was a problem hiding this comment.
The Gentoo version is actually a custom ebuild we have in the overlay, dev-python/bson.
Added in ros/ros-overlay#574.
|
@allenh1 I see |
|
@hidmic I'm honestly not sure myself at this point... Let's leave it at |
dirk-thomas
approved these changes
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added rules for:
to match
python-bsonplatform coverage. For Gentoo and OSX, the keys are the same as IIUC the Python version being targeted depends on OS configuration and package manager respectively, but I don't have boxes at hand to try this out.