Fix python-bson to pull pymongo in Gentoo #17593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently for the other distros the bson part has been generated into a different package. And the library that says it stripped from pymongo bson and made a package itself is not compatible with those neither the code that uses it.
|
@allenh1 when this gets merged, can we have another sync please? Thank you. It will still need ros/ros-overlay#578 too |
tfoote
approved these changes
Apr 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently for the other distros the
bsondependency has been generated into a different package from the mainpymongopackage. For example, Ubuntu Xenial: https://packages.ubuntu.com/xenial/python-bson comes from the same source than all pymongo.And the library
python-bsonsays it is stripped from pymongo bson and made a package itself but is not compatible with who uses it... in our caserosbridge_library.Also
python-bsonseems to be in a unstable state currently, they seem to be changing the name of the library itself (to py-bson):py-bson/bson#41
And
rosbridge_library(who actually depends on it) checks for the correct library here:https://github.com/RobotWebTools/rosbridge_suite/blob/develop/rosbridge_library/src/rosbridge_library/util/__init__.py#L19-L27
There are plenty of issues with things that are different from the
pymongobson: https://github.com/py-bson/bson/issuesUntil this
py-bsondoesn't become a real alternative, or Gentoo, or someone in ros-overlay with more time to dedicate to this headache fixes it... I think this is quite a good workaround.As a note, I noticed all this when actually running
rosbrige_serverin Gentoo. I never was able to run it until today, so I could find all this only today. What a mess.Sorry for all the noise.