Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cob_extern: 0.6.13-1 in 'kinetic/distribution.yaml' [bloom] #21920

Merged
merged 2 commits into from
Aug 7, 2019

Conversation

fmessmer
Copy link
Contributor

@fmessmer fmessmer commented Aug 6, 2019

Increasing version of package(s) in repository cob_extern to 0.6.13-1:

cob_extern

* Merge pull request #99 <https://github.com/ipa320/cob_extern/issues/99> from fmessmer/travis_melodic
  [Melodic] melodify
* remove libqsopt
* remove libconcorde_tsp_solver
* Contributors: Benjamin Maidel, fmessmer

libdlib

  • No changes

libntcan

  • No changes

libpcan

  • No changes

libphidgets

  • No changes

opengm

  • No changes

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As-is, this PR is removing two packages from Kinetic; ros-kinetic-libconcorde-tsp-solver and ros-kinetic-libqsopt. While this is something we do allow, we recommend not to do it; you are effectively abandoning any downstream consumers of it. If you still want to do it, please let us know explicitly. Thanks.

@fmessmer
Copy link
Contributor Author

fmessmer commented Aug 6, 2019

we removed the packages (from the current release) because we are striving for a kinetic/melodic-compatible release...and the removed packages are no longer supported (and broke the melodic compatibility of this repo)

our assumption was that even with removing the package in this release, they still would be available with the previos release version
is this not the case?

@clalancette
Copy link
Contributor

our assumption was that even with removing the package in this release, they still would be available with the previos release version
is this not the case?

I don't believe that is the case; I think if packages are removed from the distribution.yaml, the packages are removed on the next sync. But I'm not 100% sure of that. @tfoote , can you comment here?

@fmessmer
Copy link
Contributor Author

fmessmer commented Aug 7, 2019

could some buildfarm/release expert help to clarify this, so I can finalize our release set to fix the current regression ipa320/cob_robots#781 asap

@tfoote
Copy link
Member

tfoote commented Aug 7, 2019

The buildfarm does not actively clear packages. However they will be purged when an upstream dependency is released, and we trigger the removal of all downstream dependencies. If we didn't do that you would end up with potential crashes due to ABI incompatibility.

As such it won't be gone immediately, but it's not expected to persist for any period of time. If you want the old version to persist, it needs to be in the index at the old version. For example you could make a trimmed down duplicate (with different name) repository entry and only list these packages at the old versions if you want the old versions to persist.

Also if they're not in the index they're not accessible for any source build toolchains.

@fmessmer fmessmer force-pushed the bloom-cob_extern-8 branch from d6c279c to 5df2ed2 Compare August 7, 2019 09:17
@fmessmer
Copy link
Contributor Author

fmessmer commented Aug 7, 2019

thanks @tfoote
is 5df2ed2 what you had in mind?

@tfoote
Copy link
Member

tfoote commented Aug 7, 2019

Exactly thanks.

@tfoote tfoote merged commit 3d95726 into ros:master Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants