Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cob_manipulation: 0.7.3-1 in 'kinetic/distribution.yaml' [bloom] #23208

Merged
merged 1 commit into from
Dec 13, 2019
Merged

cob_manipulation: 0.7.3-1 in 'kinetic/distribution.yaml' [bloom] #23208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions kinetic/distribution.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1774,11 +1774,10 @@ repositories:
- cob_moveit_bringup
- cob_moveit_interface
- cob_obstacle_distance_moveit
- cob_pick_place_action
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to confirm:
I don't want to release a new version of cob_pick_place_action
If cob_pick_place_action is no longer a dependency of cob_manipulation meta-package - that is fine
I still want cob_pick_place_action to be available under the old version 0.7.2-1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it will work like that. My understanding was that a sync more-or-less deleted everything, then just uploaded the new versions of packages. But I'm not 100% sure of that. @nuclearsandwich @tfoote , can you confirm?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still waiting for confirmation/clarification on the effect of this pr...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the package here will remove it from the buildfarm. Packages in the same repository cannot target be different versions or target different tags. Options are:

  1. Continue releasing cob_pick_place_action in this repo with no changes in each version.
  2. Split the package out into a separate repository and release it once from there, it can be the same source version as is currently released you just need to bump the package revision. Then you can release this repository without affecting it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, then I'm ok with dropping cob_pick_place_action package from buildfarm for kinetic - which is what this PR is doing
Once I find the time to fix it again, I will include it again and trigger a new release that will make the package available via buildfarm again
👉 good to merge

tags:
release: release/kinetic/{package}/{version}
url: https://github.com/ipa320/cob_manipulation-release.git
version: 0.7.2-1
version: 0.7.3-1
source:
type: git
url: https://github.com/ipa320/cob_manipulation.git
Expand Down