Handle None as return value for call_pkg_config #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of a proposed fix for ros-infrastructure/rosdep#34 A failed call to pkg-config should give a more clear error message instead of a stack trace.
|
This pull request relies on ros-infrastructure/rosdep#227 to make sense. |
|
Is the new message okay? |
ghost
assigned
|
None of the other messages contain the message package and especially the message you changed does not fail because of the specific message but due to a general problem of not being able to invoke pkg-config. |
|
Actually, the None return value does not indicate a general problem but a non-zero exit code from pkg-config. According to the manual that means that pkg-config does not know the queried package. I think it would be a good idea to state this fact in the error message to ease troubleshooting. |
dirk-thomas
added a commit
that referenced
this pull request
Mar 1, 2013
PierrickKoch
referenced
this pull request
in PierrickKoch/robotpkg
Feb 21, 2014
While here, rename the package to ros-rospack, for consistency with other ros packages. The ChangeLog since 2.0.13 stops at the "groovy" boundary. 2.1.19 (2013-06-06) ------------------- * modified command 'list-duplicates' to output the paths where the packages were found (`#3 <https://github.com/ros/rospack/issues/3>`_) * modified 'rospack plugins' to not use rosdep (`#5 <https://github.com/ros/rospack/issues/5>`_) * improve Windows support (`#10 <https://github.com/ros/rospack/issues/10>`_) * use find_package() for tinyxml (if available) 2.1.18 (2013-03-21) ------------------- * invert order of package type detection (dry before wet) (`ros-infrastructure/rospkg#30 <https://github.com/ros/rospkg/issues/30>`_) 2.1.17 (2013-03-08) ------------------- * output full pkg-config command in case of errors (`#8 <https://github.com/ros/rospack/issues/8>`_) * handle None as return value for call_pkg_config (`#8 <https://github.com/ros/rospack/issues/8>`_) * fix crawling to always recrawl when forced (`#9 <https://github.com/ros/rospack/issues/9>`_) 2.1.16 (2013-01-13) ------------------- * fix segfault for command depends1 which ignores exceptions and calls isSysPackage again (`#4 <https://github.com/ros/rospack/issues/4>`_) 2.1.15 (2012-12-06) ------------------- * first public release for Groovy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of a proposed fix for ros-infrastructure/rosdep#34
A failed call to pkg-config should give a more
clear error message instead of a stack trace.