Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Humble / Rolling build #9

Closed
wants to merge 2 commits into from
Closed

Fix Humble / Rolling build #9

wants to merge 2 commits into from

Conversation

chapulina
Copy link
Contributor

This PR has the bare minimum to get GitHub actions running and passing for the ros2 branch.

  • Update from sdformat9 to sdformat12. Version 12 is the first to be supported on Jammy.
  • The header moves are needed for cpplint to pass on Humble
  • While moving the headers, I went ahead and made them narrower to speed up compilation

@sloretz
Copy link
Contributor

sloretz commented Jun 3, 2022

Looks like the sdformat12 rosdep key needs an entry on Jammy

https://github.com/ros/rosdistro/blob/8db58d767c12ffca910ccefd2068765cf11bcb63/rosdep/base.yaml#L7076-L7080

13:05:37 Traceback (most recent call last):
13:05:37   File "/tmp/ros_buildfarm/scripts/devel/create_devel_task_generator.py", line 306, in <module>
13:05:37     main()
13:05:37   File "/tmp/ros_buildfarm/scripts/devel/create_devel_task_generator.py", line 138, in main
13:05:37     debian_pkg_names_building = resolve_names(build_depends, **context)
13:05:37   File "/tmp/ros_buildfarm/scripts/devel/create_devel_task_generator.py", line 289, in resolve_names
13:05:37     resolved_names = resolve_for_os(
13:05:37   File "/usr/lib/python3/dist-packages/rosdep2/catkin_support.py", line 91, in resolve_for_os
13:05:37     inst_key, rule = d.get_rule_for_platform(os_name, os_version, os_installers, default_os_installer)
13:05:37   File "/usr/lib/python3/dist-packages/rosdep2/lookup.py", line 132, in get_rule_for_platform
13:05:37     raise ResolutionError(rosdep_key, self.data, os_name, os_version, 'No definition of [%s] for OS version [%s]' % (rosdep_key, os_version))
13:05:37 rosdep2.lookup.ResolutionError: No definition of [sdformat12] for OS version [jammy]
13:05:37 	rosdep key : sdformat12
13:05:37 	OS name    : ubuntu
13:05:37 	OS version : jammy
13:05:37 	Data:
13:05:37 debian:
13:05:37 		  buster:
13:05:37 		  - libsdformat12-dev
13:05:37 		ubuntu:
13:05:37 		  focal:
13:05:37 		  - libsdformat12-dev

@chapulina
Copy link
Contributor Author

Looks like the sdformat12 rosdep key needs an entry on Jammy

Ouch, my bad, here we go:

chapulina added 2 commits June 3, 2022 16:07
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina changed the base branch from ros2 to sloretz__ci_focal_jammy June 3, 2022 23:08
@chapulina
Copy link
Contributor Author

Rebased on top of #10

@chapulina chapulina changed the title Fix Humble / Rolling build and add GitHub actions CI Fix Humble / Rolling build Jun 3, 2022
@sloretz sloretz deleted the branch ros:sloretz__ci_focal_jammy June 3, 2022 23:09
@sloretz sloretz closed this Jun 3, 2022
@chapulina
Copy link
Contributor Author

Ouch 😕 @sloretz I had updated this PR to have only the source code updates

@sloretz
Copy link
Contributor

sloretz commented Jun 3, 2022

Ah ooops I didn't mean to close this, and I can't seem to reopen it. I deleted the branch sloretz__ci_focal_jammy after merging #10. That seems to put this PR in a bad state since it was targeting that branch. I can't even re-target it to the ros2 branch :(

@chapulina
Copy link
Contributor Author

haha no worries, I can open a new PR

@chapulina chapulina deleted the chapulina/ros2/actions branch June 3, 2022 23:25
@chapulina
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants