-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI for Focal and Jammy #10
Conversation
I completly spaced that we can't really test
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - that is CI fails where I would expect it to (failing to find SDFormat9 on Jammy). Adding the GAZEBO_VERSION
logic and support for sdformat12
should fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, I've never used actions from setup-ros
because I usually need to inject custom logic, such as pulling packages from packages.osrfoundation.org
, or skipping unknown rosdep keys. I wonder how it will handle the condition
s on package.xml
when it invokes rosdep
. It will be great if it just works!
.github/workflows/focal-ci.yaml
Outdated
@@ -0,0 +1,28 @@ | |||
name: focal-ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you checked that this will work for the galactic
branch even if it's merged into the ros2
branch?
In case it only works when it's backported to galactic
, I'd argue that it's best not to add galactic CI information to the ros2
branch. Instead, you could give the yaml file a generic name, like ci.yaml
, and modify it according to the branch. This also helps comparing it across branches, for example:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the PR to have a generic name ci.yaml
, but I don't have a specific commit with the change since I rebased and squashed to add the sign-off.
b42c0c2
to
816f940
Compare
Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
816f940
to
4681b4c
Compare
Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating. It looks like this should work, we'll know once the rosdep key and the source code changes from #9 are in.
* CI for Focal and Jammy Signed-off-by: Shane Loretz <sloretz@openrobotics.org> * Only run on pull_request updates Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
* CI for Focal and Jammy (#10) * CI for Focal and Jammy Signed-off-by: Shane Loretz <sloretz@openrobotics.org> * Only run on pull_request updates Signed-off-by: Shane Loretz <sloretz@openrobotics.org> * Focal;Galactic;Citadel,Edifice,Fortress Signed-off-by: Shane Loretz <sloretz@openrobotics.org> * Gazebo -> gz Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
* CI for Focal and Jammy (#10) * CI for Focal and Jammy Signed-off-by: Shane Loretz <sloretz@openrobotics.org> * Only run on pull_request updates Signed-off-by: Shane Loretz <sloretz@openrobotics.org> * Focal;Galactic;Citadel,Edifice,Fortress Signed-off-by: Shane Loretz <sloretz@openrobotics.org> * Galactic: Support Citadel, Edifice and Fortress Signed-off-by: Louise Poubel <louise@openrobotics.org> * Remove custom action Signed-off-by: Louise Poubel <louise@openrobotics.org> * cascading logic Signed-off-by: Louise Poubel <louise@openrobotics.org> * gazebo -> gz Signed-off-by: Louise Poubel <louise@openrobotics.org> * oops Signed-off-by: Louise Poubel <louise@openrobotics.org> * Reorder things Signed-off-by: Louise Poubel <louise@openrobotics.org> * Fix tests with Edifice Signed-off-by: Louise Poubel <louise@openrobotics.org> * no gz-utils for SDF 9 Signed-off-by: Louise Poubel <louise@openrobotics.org> * uncrustify Signed-off-by: Louise Poubel <louise@openrobotics.org> * Apply suggestions from code review Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Shane Loretz <shane.loretz@gmail.com> * Citadel Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Shane Loretz <sloretz@osrfoundation.org> Co-authored-by: Shane Loretz <sloretz@openrobotics.org> Co-authored-by: Shane Loretz <shane.loretz@gmail.com>
@chapulina this is what I had in mind for CI. I'm a bit weak on github actions so there may be syntax errors here. It uses some actions from https://github.com/ros-tooling/setup-ros