-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python warnings are not reported by CI #418
Comments
@jacobperron were you able to make Jenkins pick up those warnings? |
@hidmic No, I didn't look into it too deeply. |
Current aim is to try and figure out whether the existing Jenkins plugins can be configured to pick up python warnings in |
I did some checking and it doesn't appear that a python warning parser exists as part of the Jenkins analysis-model nor is there a separate plugin which provides one. I did manage to write a regexp-based parser to extract Python warnings from Pytest warnings summaries from colcon test stderr logs. #447 is a PR which adds a parser for the warnings as they appear in our colcon logs. |
The It is up to Jenkins to extract those and change the build status based on it. See #509 for a draft PR doing that. |
Neither
colcon test
nor Jenkins report warnings coming from Python code. For example, deprecated API was recently introduced in ros2/ros2cli#463 but CI passes without reported the warnings. I would expect an unstable build so that we notice things like deprecated Python APIs and can address them.Here is an example build testing
ros2node
:It is unstable for a different reason. The point is there are 61 warnings visible in the console, but they are not reported by Jenkins: https://ci.ros2.org/job/ci_linux/9731/consoleFull#console-section-223
Specifically for tests, I tried passing a pytest argument to treat warnings as errors (#416), but this results in a failed build, instead of unstable, which I think is not desired.
Related colcon PR to report pytest warnings: colcon/colcon-core#236
The text was updated successfully, but these errors were encountered: