Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redirect pytest warnings summary to stderr #236

Conversation

dirk-thomas
Copy link
Member

With the goal to make them more visible. A package can always opt to filter the warnings using e.g. the filterwarnings option in a pytest.ini file.

@dirk-thomas dirk-thomas added enhancement New feature or request review Waiting for review (Kanban column) labels Sep 26, 2019
@dirk-thomas dirk-thomas self-assigned this Sep 26, 2019
@rotu
Copy link
Contributor

rotu commented Sep 26, 2019

Why reparse stdout instead of making sure these messages get sent to the correct stream in the first place?

@dirk-thomas
Copy link
Member Author

Why reparse stdout instead of making sure these messages get sent to the correct stream in the first place?

Do you have a suggestion how to achieve that?

@rotu
Copy link
Contributor

rotu commented Sep 26, 2019

either with the pytest_runtest_logreport, pytest_terminal_summary or pytest_warning_captured hook.

https://docs.pytest.org/en/latest/_modules/_pytest/hookspec.html

@dirk-thomas
Copy link
Member Author

Closing in favor of #338.

@dirk-thomas dirk-thomas deleted the dirk-thomas/redirect-pytest-warnings-summary-to-stderr branch April 13, 2020 05:20
@tylerjw

This comment has been minimized.

@tylerjw

This comment has been minimized.

@dirk-thomas
Copy link
Member Author

@tylerjw Your comments seem to be off topic for this ticket. colcon/colcon-cmake#67 seems to be discussing what you are referring to. Please consider to contribute a pull request to colcon-cmake to implement custom logic to separate the Ninja output.

@tylerjw
Copy link

tylerjw commented Jul 8, 2020

I'm sorry about that... I'll re-target my comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request review Waiting for review (Kanban column)
Development

Successfully merging this pull request may close these issues.

3 participants