Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pytest hook to redirect pytest warnings to stderr #338

Merged

Conversation

dirk-thomas
Copy link
Member

To avoid using the same redirect in non-colcon pytest invocations the custom hook is only changing the behavior when the environment variable COLCON is set.

@dirk-thomas dirk-thomas added the enhancement New feature or request label Apr 13, 2020
@dirk-thomas dirk-thomas self-assigned this Apr 13, 2020
@codecov
Copy link

codecov bot commented Apr 13, 2020

Codecov Report

Merging #338 into master will decrease coverage by 0.39%.
The diff coverage is 5.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #338      +/-   ##
==========================================
- Coverage   80.98%   80.59%   -0.40%     
==========================================
  Files          55       56       +1     
  Lines        3219     3236      +17     
  Branches      534      536       +2     
==========================================
+ Hits         2607     2608       +1     
- Misses        576      591      +15     
- Partials       36       37       +1     
Impacted Files Coverage Δ
colcon_core/pytest/hooks.py 0.00% <0.00%> (ø)
colcon_core/command.py 86.52% <50.00%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aae749c...7c09c6e. Read the comment docs.

colcon_core/command.py Show resolved Hide resolved
@dirk-thomas dirk-thomas force-pushed the dirk-thomas/redirect-pytest-warnings-summary-to-stderr-2 branch from b1a3d59 to 7c09c6e Compare April 14, 2020 17:42
@dirk-thomas
Copy link
Member Author

Just rebased thinking I could get Codecov to turn green... I guess I was wrong 😞

@dirk-thomas dirk-thomas merged commit 58acc58 into master Apr 14, 2020
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/redirect-pytest-warnings-summary-to-stderr-2 branch April 14, 2020 17:47
@dirk-thomas dirk-thomas added this to the 0.5.8 milestone Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants