Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add equidistant distortion model #161

Closed
wants to merge 1 commit into from

Conversation

mintar
Copy link
Contributor

@mintar mintar commented Nov 12, 2021

This is a backport of #160 to ROS2 Foxy.

This is a forward-port from ROS1 noetic:

ros/common_msgs#109

The model is based on the following publication:

J. Kannala and S. Brandt (2006). A Generic Camera Model and Calibration
Method for Conventional, Wide-Angle, and Fish-Eye Lenses, IEEE
Transactions on Pattern Analysis and Machine Intelligence, vol. 28, no.
8, pp. 1335-1340

There are many different names for this distortion model:

* Kannala and Brandt call it "Generic Camera Model". Sometimes they also
  call it "equidistance projection model".
* Kalibr calls it "equidistant": https://github.com/ethz-asl/kalibr/wiki/supported-models
* Camodocal calls it "kannala-brandt": https://github.com/hengli/camodocal
* OpenCV calls it "fisheye": https://stackoverflow.com/a/34309644/3036576

All of these are just different names for the same model.

Signed-off-by: Martin Günther <martin.guenther@dfki.de>
@clalancette
Copy link
Contributor

I'm actually going to close this and use the bot to do backports of #160 to Foxy and Galactic.

@mintar mintar deleted the add_equidistant_distortion_foxy branch December 3, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants