Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix generating unique files on Windows #102

Merged
merged 1 commit into from
Dec 20, 2016
Merged

fix generating unique files on Windows #102

merged 1 commit into from
Dec 20, 2016

Conversation

dirk-thomas
Copy link
Member

@dirk-thomas dirk-thomas added the in review Waiting for review (Kanban column) label Dec 20, 2016
@dirk-thomas dirk-thomas self-assigned this Dec 20, 2016
@dhood dhood added the in progress Actively being worked on (Kanban column) label Dec 20, 2016
dirk-thomas referenced this pull request Dec 20, 2016
@wjwwood
Image tools tests redux (#67)
16c3bc5 
* add tests for cam2image and showimage

* use burger mode (-b) instead of movie for tests

* add a frequency option to the cam2image program

* transparent burgers

* proper burger masking

* windows

* missing Windows include

* fix warnings for Windows

* warnings on Windows

* fix signed/unsigned comparison warnings

* fix Windows warnings
@dirk-thomas dirk-thomas removed the in progress Actively being worked on (Kanban column) label Dec 20, 2016
@codebot
Copy link
Member

codebot commented Dec 20, 2016

where does $<CONFIGURATION> get set in CMake / ament? Unfortunately it is basically impossible to Google for "cmake configuration variable" 😄

@dirk-thomas
Copy link
Member Author

The keywords are "CMake generator expressions": https://cmake.org/cmake/help/v3.5/manual/cmake-generator-expressions.7.html

@codebot
Copy link
Member

codebot commented Dec 20, 2016

Ah, thanks for the pointer, that's good to know. My only super-trivial comment then is that the CMake doc page for generator expressions says that $<CONFIGURATION> is deprecated and to use $<CONFIG> instead. But that isn't important for now, so this looks good to me either way. 👍

@dirk-thomas dirk-thomas force-pushed the fix_generating_unique_files branch from 16f41b0 to a3a36fd Compare December 20, 2016 18:13
@dirk-thomas
Copy link
Member Author

Good point. I changed it to <CONFIG>. If http://ci.ros2.org/job/ci_windows/2120/ passes I will merge this.

@dirk-thomas dirk-thomas merged commit 2b5722a into master Dec 20, 2016
@dirk-thomas dirk-thomas deleted the fix_generating_unique_files branch December 20, 2016 18:38
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Dec 20, 2016
@wjwwood
Copy link
Member

wjwwood commented Dec 20, 2016

Thanks.

@dirk-thomas
Copy link
Member Author

I have updated the existing code base to use <CONFIG> instead of <CONFIGURATION>:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebot codebot codebot approved these changes

Assignees

@dirk-thomas dirk-thomas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dirk-thomas @codebot @wjwwood @dhood