Install includes to include/${PROJECT_NAME}

[sloretz]

Part of ros2/ros2#1150

This installs includes to include/${PROJECT_NAME} to mitigate include directory search order issues when overriding packages in desktop.

Part of ament/ament_cmake#365

This removes ament_export_libraries and ament_export_include_directories as they're redundant with the exported CMake targets. Edit: Added back old-style CMake variables to minimize disruption

Part of ament/ament_cmake#292

This replaces ament_target_dependencies() calls with target_link_libraries().

Requires ros2/rclcpp#1855 for the rclcpp_components::component target.

[clalancette]

Looks generally good to me. The Rpr job should be fixed when ros-visualization/rqt_image_view#62 is released.

[sloretz]

CI

• repos file
• build: --packages-up-to action_tutorials_cpp action_tutorials_interfaces action_tutorials_py composition demo_nodes_cpp demo_nodes_cpp_native demo_nodes_py dummy_map_server dummy_robot_bringup dummy_sensors image_tools intra_process_demo lifecycle lifecycle_py logging_demo pendulum_control pendulum_msgs quality_of_service_demo_cpp quality_of_service_demo_py topic_monitor topic_statistics_demo
• test: --packages-select action_tutorials_cpp action_tutorials_interfaces action_tutorials_py composition demo_nodes_cpp demo_nodes_cpp_native demo_nodes_py dummy_map_server dummy_robot_bringup dummy_sensors image_tools intra_process_demo lifecycle lifecycle_py logging_demo pendulum_control pendulum_msgs quality_of_service_demo_cpp quality_of_service_demo_py topic_monitor topic_statistics_demo)

Jobs

• Linux
• Linux-aarch64
• Windows

[Blast545]

👨‍🌾 It seems this PR caused a build regression in the windows_packaging jobs:
https://ci.ros2.org/view/packaging/job/packaging_windows/2367/

Can you please take a look @sloretz ? 🙏

[ivanpauno]

The Rpr checker was not passing when this was merged and it's still not passing (e.g. #552).
It seems that there has already been a rclcpp rolling release after that, which included ros2/rclcpp#1855 (https://github.com/ros2/rclcpp/commits/15.0.0).
The rosdistro PR was merged 7 days ago, so I guess a sync in the testing repo has already happened.

[sloretz]

I guess a sync in the testing repo has already happened.

@ivanpauno A sync to testing has not happened: http://repo.ros2.org/status_page/rolling_default.html?q=ros-rolling-rclcpp . Building has rclcpp 15.0.0, but testing still has 14.1.0. The PR job will pass when the sync to testing happens.

[ivanpauno]

@ivanpauno A sync to testing has not happened: http://repo.ros2.org/status_page/rolling_default.html?q=ros-rolling-rclcpp . Building has rclcpp 15.0.0, but testing still has 14.1.0. The PR job will pass when the sync to testing happens.

Thanks for the link! I didn't know how to check that.