Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use default on_activate()/on_deactivate implemenetation of Node #552

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Use default on_activate()/on_deactivate implemenetation of Node #552

merged 1 commit into from
Jan 24, 2022

Conversation

ivanpauno
Copy link
Member

@ivanpauno
Use default on_activate()/on_deactivate implemenetation of Node
4959ca9 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno self-assigned this Jan 13, 2022
@ivanpauno ivanpauno added the enhancement New feature or request label Jan 13, 2022
@ivanpauno ivanpauno mentioned this pull request Jan 13, 2022
Merged
@ivanpauno
Copy link
Member Author

CI passed here.
I will do a new rclcpp release before merging this.

@ivanpauno
Copy link
Member Author

@ros-pull-request-builder retest this please

1 similar comment
@ivanpauno
Copy link
Member Author

@ros-pull-request-builder retest this please

@ivanpauno
Copy link
Member Author

I couldn't reproduce the issue locally, once again:

@ros-pull-request-builder retest this please.

@ivanpauno ivanpauno mentioned this pull request Jan 21, 2022
Merged
@clalancette
Copy link
Contributor

@ros-pull-request-builder retest this please.

@ivanpauno ivanpauno merged commit bee316c into master Jan 24, 2022
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/lifecycle-automatically-transition-entities branch January 24, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

Assignees

@ivanpauno ivanpauno

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivanpauno @clalancette @jacobperron