Skip to content

update launch file names to match recommended format #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

patrickwasp
Copy link
Contributor

@patrickwasp patrickwasp commented Nov 4, 2022

companion pull request for ros2/ros2_documentation#3166

@fujitatomoya
Copy link
Collaborator

@patrickwasp can you address DCO?

@patrickwasp
Copy link
Contributor Author

@fujitatomoya DCO fixed

Copy link
Member

@audrow audrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with green CI.

@fujitatomoya
Copy link
Collaborator

@audrow can you take care of this? i do not have write permission to this repository.

Signed-off-by: Patrick Wspanialy <patrick.wspanialy@ecoation.com>
@clalancette
Copy link
Contributor

Sorry for the delay here. I've now rebased this and fixed a few other things that have changed in the meantime. I'm going to approve and run CI on it next.

@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants