Skip to content

update launch file names to match recommended format #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composition/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ ros2 run composition linktime_composition
Rather than using the command line tool to run each composition, we can **automate this action** with `ros2 launch` functionality:

```bash
ros2 launch composition composition_demo.launch.py
ros2 launch composition composition_demo_launch.py
```

## Verify
Expand Down
2 changes: 1 addition & 1 deletion demo_nodes_cpp/src/services/introspection_client.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
//
// To see this in action, run the following:
//
// ros2 launch demo_nodes_cpp introspect_services.launch.py
// ros2 launch demo_nodes_cpp introspect_services_launch.py
// Since the default for introspection is 'off', this is no different than
// a normal client and server. No additional topics will be made, and
// no introspection data will be sent. However, changing the introspection
Expand Down
2 changes: 1 addition & 1 deletion demo_nodes_cpp/src/services/introspection_service.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
//
// To see this in action, run the following:
//
// ros2 launch demo_nodes_cpp introspect_services.launch.py
// ros2 launch demo_nodes_cpp introspect_services_launch.py
// Since the default for introspection is 'off', this is no different than
// a normal client and server. No additional topics will be made, and
// no introspection data will be sent. However, changing the introspection
Expand Down
2 changes: 1 addition & 1 deletion lifecycle/README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ Alternatively, these three programs can be run together in the same terminal usi

.. code-block:: bash

ros2 launch lifecycle lifecycle_demo.launch.py
ros2 launch lifecycle lifecycle_demo_launch.py

If we look at the output of the ``lifecycle_talker``\ , we notice that nothing seems to happen.
This makes sense, since every node starts as ``unconfigured``.
Expand Down
2 changes: 1 addition & 1 deletion lifecycle_py/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
['resource/' + package_name]),
('share/' + package_name, ['package.xml']),
('share/lifecycle_py/launch',
glob.glob(os.path.join('launch', '*.launch.py'))),
glob.glob(os.path.join('launch', '*_launch.py'))),
],
install_requires=['setuptools'],
zip_safe=True,
Expand Down
6 changes: 3 additions & 3 deletions topic_monitor/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ ros2 run topic_monitor topic_monitor --display
### Comparing reliability QoS settings
You will need two machines with ROS 2: one mobile and one stationary.

1. Run the `ros2 launch topic_monitor reliability_demo.launch.py` executable on the stationary machine.
1. Run the `ros2 launch topic_monitor reliability_demo_launch.py` executable on the stationary machine.
This will start two nodes: one publishing in “reliable” mode, and one in “best effort”.
1. Start the monitor on a mobile machine such as a laptop.
Use `ros2 run topic_monitor topic_monitor --display --allowed-latency 5` to account for any latency that may occur re-sending the reliable messages.
Expand Down Expand Up @@ -54,7 +54,7 @@ If the 10th latest message has not been successfully acknowledged by the time th

You will need two machines with ROS 2: one mobile and one stationary.

1. Run the `ros2 launch topic_monitor depth_demo.launch.py` executable on the stationary machine.
1. Run the `ros2 launch topic_monitor depth_demo_launch.py` executable on the stationary machine.
This will start some nodes publishing both small (payload of 1-character string) and large data (payload of 100,000-character string) with different depths: a pair publishing with a depth of 1, and a pair with a larger depth (50).
1. Start the monitor on a mobile machine such as a laptop with `ros2 run topic_monitor topic_monitor --display`.
1. Take the mobile machine out of range of the monitor, and observe how the reception rates differ for the different topics.
Expand All @@ -74,7 +74,7 @@ You will need two machines running ROS 2: one stationary and one mobile.
You should not use the Fast RTPS ROS middleware implementation for this part.
See [DDS and ROS Middleware Implementations](https://docs.ros.org/en/rolling/Concepts/About-Different-Middleware-Vendors.html) for instructions on how to change the vendor.

1. Run the `ros2 launch topic_monitor fragmentation_demo.launch.py` executable on the stationary machine.
1. Run the `ros2 launch topic_monitor fragmentation_demo_launch.py` executable on the stationary machine.
1. Run `ros2 run topic_monitor topic_monitor --display --expected-period 4` on the mobile machine.
This will launch four publishers publishing messages of strings of different lengths: small (1), medium (50000), large (100000) and xlarge (150000).
1. Take the mobile machine out of range of the monitor, and observe how the reception rates differ for the different topics.
Expand Down
2 changes: 1 addition & 1 deletion topic_monitor/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
['resource/' + package_name]),
('share/' + package_name, ['package.xml']),
('share/topic_monitor/launch',
glob.glob(os.path.join('launch', '*.launch.py'))),
glob.glob(os.path.join('launch', '*_launch.py'))),
],
install_requires=[
'launch',
Expand Down