Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use conditional rather than return to short circuit tests #78

Merged
merged 1 commit into from
Sep 14, 2016
Merged

use conditional rather than return to short circuit tests #78

merged 1 commit into from
Sep 14, 2016

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented Sep 14, 2016

@tfoote tfoote added the in progress Actively being worked on (Kanban column) label Sep 14, 2016
@wjwwood wjwwood added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Sep 14, 2016
dirk-thomas
dirk-thomas approved these changes Sep 14, 2016
View reviewed changes
Copy link
Member

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wjwwood wjwwood mentioned this pull request Sep 14, 2016
Merged
@wjwwood wjwwood merged commit 7505748 into master Sep 14, 2016
@wjwwood wjwwood deleted the no_return_in_macro branch September 14, 2016 20:58
@tfoote tfoote removed the in review Waiting for review (Kanban column) label Sep 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wjwwood @dirk-thomas @tfoote