Add documentation on node parameter #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the documentation to indicate that the `__name` parameter provides the same functionality as `__node`. Also fix some incorrect references to ROS1 behavior. Related to ros2/rcl#258.
Co-Authored-By: Michel Hidalgo <michel@ekumenlabs.com>
|
@hidmic Can this be merged now that the related ticket has been resolved? |
|
@hidmic bump |
|
Thanks for the bump guys, and apologies for the delay. Thank you for your contribution @pjreed! |
mlanting
pushed a commit
to mlanting/design
that referenced
this pull request
Aug 17, 2020
* Add documentation on node parameter Update the documentation to indicate that the `__name` parameter provides the same functionality as `__node`. Also fix some incorrect references to ROS1 behavior. Related to ros2/rcl#258. * Update articles/141_static_remapping.md Co-Authored-By: Michel Hidalgo <michel@ekumenlabs.com> Co-authored-by: Michel Hidalgo <michel@ekumenlabs.com>
mlanting
pushed a commit
to mlanting/design
that referenced
this pull request
Aug 17, 2020
* Add documentation on node parameter Update the documentation to indicate that the `__name` parameter provides the same functionality as `__node`. Also fix some incorrect references to ROS1 behavior. Related to ros2/rcl#258. * Update articles/141_static_remapping.md Co-Authored-By: Michel Hidalgo <michel@ekumenlabs.com> Co-authored-by: Michel Hidalgo <michel@ekumenlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the documentation to indicate that the
__nameparameter provides the same functionality as__node. Also fix some incorrect references to ROS1 behavior.Related to ros2/rcl#258.