Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use __name instead of __node for consistency with ROS 1 #258

Closed
wjwwood opened this issue Jun 9, 2018 · 0 comments · Fixed by #494
Closed

use __name instead of __node for consistency with ROS 1 #258

wjwwood opened this issue Jun 9, 2018 · 0 comments · Fixed by #494
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@wjwwood
Copy link
Member

wjwwood commented Jun 9, 2018

Feature request

Feature description

@codebot pointed out to me that ROS 1 uses __name and not __node for remapping the node name over the command-line, see:

https://wiki.ros.org/Nodes#Remapping_Arguments.Special_keys

The use of __node in ROS 2 is likely due to me randomly using it in the design document:

http://design.ros2.org/articles/topic_and_service_names.html#substitutions

Implementation considerations

We'd also want to update any documentation and the design doc:

http://design.ros2.org/articles/static_remapping.html#change-the-node-name

We could also consider supporting both, or doing a tick-tock on __node, but supporting __name at some point for consistency makes sense to me.
@wjwwood wjwwood added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jun 9, 2018
pjreed added a commit to pjreed/rcl that referenced this issue Aug 28, 2019
@pjreed
Treat __name the same as __node
a5628f8 
This modifies the lexer so that it will accept __name and treat it
exactly the same as __node.  __node still works in order to preserve
backwards compatibility.

Fixes ros2#258

Distro A; OPSEC #2893

Signed-off-by: P. J. Reed <preed@swri.org>
pjreed added a commit to pjreed/rcl that referenced this issue Aug 28, 2019
@pjreed
Treat __name the same as __node
dc8c232 
This modifies the lexer so that it will accept __name and treat it
exactly the same as __node.  __node still works in order to preserve
backwards compatibility.

Fixes ros2#258

Distro A; OPSEC #2893

Signed-off-by: P. J. Reed <preed@swri.org>
pjreed added a commit to pjreed/rcl that referenced this issue Sep 3, 2019
@pjreed
Treat __name the same as __node
f2c07ba 
This modifies the lexer so that it will accept __name and treat it
exactly the same as __node.  __node still works in order to preserve
backwards compatibility.

Fixes ros2#258

Distribution Statement A; OPSEC #2893

Signed-off-by: P. J. Reed <preed@swri.org>
@pjreed pjreed mentioned this issue Sep 4, 2019
Merged
pjreed added a commit to pjreed/design that referenced this issue Nov 4, 2019
@pjreed
Add documentation on node parameter
67be058 
Update the documentation to indicate that the `__name` parameter provides the same functionality as `__node`.  Also fix some incorrect references to ROS1 behavior.

Related to ros2/rcl#258.
@pjreed pjreed mentioned this issue Nov 4, 2019
Merged
hidmic pushed a commit that referenced this issue Nov 22, 2019
@pjreed @hidmic
Treat __name the same as __node (#494)
8af6f17 
* Treat __name the same as __node

This modifies the lexer so that it will accept __name and treat it
exactly the same as __node.  __node still works in order to preserve
backwards compatibility.

Fixes #258

Distribution Statement A; OPSEC #2893

Signed-off-by: P. J. Reed <preed@swri.org>

* Update dot graph for lexer

Distribution Statement A; OPSEC #2893

Signed-off-by: P. J. Reed <preed@swri.org>
hidmic added a commit to ros2/design that referenced this issue Mar 9, 2020
@pjreed @hidmic
Add documentation on node parameter (#263)
6ed935f 
* Add documentation on node parameter

Update the documentation to indicate that the `__name` parameter provides the same functionality as `__node`.  Also fix some incorrect references to ROS1 behavior.

Related to ros2/rcl#258.

* Update articles/141_static_remapping.md

Co-Authored-By: Michel Hidalgo <michel@ekumenlabs.com>

Co-authored-by: Michel Hidalgo <michel@ekumenlabs.com>
mlanting pushed a commit to mlanting/design that referenced this issue Aug 17, 2020
@pjreed @hidmic @mlanting
Add documentation on node parameter (ros2#263)
6a909aa 
* Add documentation on node parameter

Update the documentation to indicate that the `__name` parameter provides the same functionality as `__node`.  Also fix some incorrect references to ROS1 behavior.

Related to ros2/rcl#258.

* Update articles/141_static_remapping.md

Co-Authored-By: Michel Hidalgo <michel@ekumenlabs.com>

Co-authored-by: Michel Hidalgo <michel@ekumenlabs.com>
mlanting pushed a commit to mlanting/design that referenced this issue Aug 17, 2020
@pjreed @hidmic @mlanting
Add documentation on node parameter (ros2#263)
6ce3808 
* Add documentation on node parameter

Update the documentation to indicate that the `__name` parameter provides the same functionality as `__node`.  Also fix some incorrect references to ROS1 behavior.

Related to ros2/rcl#258.

* Update articles/141_static_remapping.md

Co-Authored-By: Michel Hidalgo <michel@ekumenlabs.com>

Co-authored-by: Michel Hidalgo <michel@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Treat __name the same as __node pjreed/rcl
1 participant
@wjwwood