Add an example about how to use wait_for_all_acked #316
Conversation
|
If pre-shutdown callback is supported (ros2/rclcpp#1706 (comment)), I can simplify current codes. |
|
probably it would be nice to have only specified example to introduce |
Yes. |
|
@Barry-Xu-2018 can we also have example for |
Yeah. I will consider adding this example. |
|
we can run CI once ros2/rclcpp#1662 is merged. |
|
Example code for python isn't added. |
Barry-Xu-2018
force-pushed
the
topic-example-for-wait_for_all_acked
branch
from
7af8c38
to
d00623d
Compare
|
do rebase |
|
@ros-pull-request-builder retest this please |
|
@clalancette it appears that CI still does not have ros2/rclcpp#1662, that leads this PR to build failure. Do you know how long it takes? i was thinking this is done by nightly build. |
So for the Rpr job to pass, we need to make an explicit source and bloom release to get PRs in. I can do one of those later today. That said, you should be able to run a CI job from https://ci.ros2.org to verify this functionality on all platforms, and that will include the latest sources. |
|
CI: (just checking if it can be build with mainline since there is no test for examples)
|
|
I update code to fix build warning on macOS. |
|
|
@ros-pull-request-builder retest this please |
|
@ivanpauno @sloretz @clalancette could you help this with review? |
|
@ros-pull-request-builder retest this please |
| @@ -26,6 +26,9 @@ ament_target_dependencies(publisher_member_function_with_type_adapter rclcpp std | |||
| add_executable(publisher_member_function_with_unique_network_flow_endpoints member_function_with_unique_network_flow_endpoints.cpp) | |||
| ament_target_dependencies(publisher_member_function_with_unique_network_flow_endpoints rclcpp std_msgs) | |||
|
|
|||
| add_executable(publisher_member_function_with_wait_for_all_acked member_function_with_wait_for_all_acked.cpp) | |||
There was a problem hiding this comment.
can we use a shorter name for the example?
It really doesn't matter if this is using a "member function", I think we could rather use "publisher_wait_for_all_acked".
| #include <inttypes.h> | ||
|
|
||
| #include <chrono> | ||
| #include <functional> |
There was a problem hiding this comment.
| #include <inttypes.h> | |
| #include <chrono> | |
| #include <functional> | |
| #include <chrono> | |
| #include <cstdint> | |
| #include <functional> |
There was a problem hiding this comment.
PRId64 is included in cinttypes. So I include cinttypes instead of cstdint and adjust the order of header file as your advice.
rclcpp/topics/minimal_publisher/member_function_with_wait_for_all_acked.cpp
Show resolved
Hide resolved
Signed-off-by: Barry Xu <barry.xu@sony.com>
Signed-off-by: Barry Xu <barry.xu@sony.com>
Signed-off-by: Barry Xu <barry.xu@sony.com>
Signed-off-by: Barry Xu <barry.xu@sony.com>
Signed-off-by: Barry Xu <barry.xu@sony.com>
Barry-Xu-2018
force-pushed
the
topic-example-for-wait_for_all_acked
branch
from
d9ea59d
to
ce5e34f
Compare
|
Friendly ping @ivanpauno |
|
@ivanpauno really appreciate for helping on this, thanks 👍 |
This commit depends on the merge of ros2/rcl#913 and ros2/rclcpp#1662.