separate callback_group from subscription options #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iuhilnehc-ynos requesting review. |
|
@clalancette @ahcorde could you take a look? |
tfoote
requested changes
Jan 5, 2022
There was a problem hiding this comment.
Since we now have the ability to pass the callback group in directly to the callback function. The local copies of the options injecting the options can be removed too.
This should also be reviewed for how far it can be backported since it's using the new API.
|
@ahcorde @clalancette requesting maintainer review. |
|
@ahcorde @clalancette friendly ping. |
aligned with ros2/rclcpp#1833 Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Tully Foote <tfoote@osrfoundation.org>
fujitatomoya
force-pushed
the
topic-subscription-not-hold-callback-group
branch
from
5b4a184 to
0e7121e
Compare
wjwwood
approved these changes
May 18, 2022
|
closing because of ros2/rclcpp#1833 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aligned with ros2/rclcpp#1833
Signed-off-by: Tomoya Fujita Tomoya.Fujita@sony.com