Suppress rclcpp deprecation warnings in unit tests #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Said tests have to be removed once the deprecated signatures are removed from rclcpp. Signed-off-by: Abrar Rahman Protyasha <abrar@openrobotics.org>
|
CI (build/test:
|
|
Ignore the botched CI job. The warnings came from I am running a full CI instead to target all the changes necessitated by the deprecation in ros2/rclcpp#1713.
|
|
Yellow CI for Windows is unrelated to this package - originates from |
wjwwood
approved these changes
Aug 21, 2021
delete-merged-branch
bot
deleted the
aprotyas/deprecate-shared-ptr-sub-callback
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ros2/rclcpp#1713 deprecates the
void shared_ptr<T>subscription callback signatures, so this PR introduces theRCLCPP_AVOID_DEPRECATIONS_FOR_UNIT_TESTSmacro to suppress warnings from the tests requiring these deprecated signatures.Said tests (those with
NonConstHelper) have to be removed once the deprecated signatures are removed fromrclcpp.Signed-off-by: Abrar Rahman Protyasha abrar@openrobotics.org