-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
__ns remapping not working when specified for a particular node #262
Labels
bug
Something isn't working
Comments
I would also consider that to be a bug. |
definitely a bug There's a unit test for rcl/rcl/test/rcl/test_remap.cpp Lines 55 to 86 in c9fe312
but there's not an integration test for it https://github.com/ros2/rcl/blob/master/rcl/test/rcl/test_remap_integration.cpp |
Yeah I have one prepared that fails, will open a pr for the test
…On Tue., 19 Jun. 2018, 08:18 Shane Loretz, ***@***.***> wrote:
definitely a bug
There's a unit test for rcl_remap_node_namespace()
https://github.com/ros2/rcl/blob/c9fe312674f8c5a2c5b40b6208c830f4ca8c40ff/rcl/test/rcl/test_remap.cpp#L55-L86
but there's not an integration test for it
https://github.com/ros2/rcl/blob/master/rcl/test/rcl/test_remap_integration.cpp
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#262 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFW5nGYfiMnox_c-dQO-DkhGzF5fgdM5ks5t-RZjgaJpZM4Us2TX>
.
|
Fixed and tested in #263 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This works:
As does this:
But this doesn't seem to:
There's a chance this combination isn't expected to work, but I think it might be.
The text was updated successfully, but these errors were encountered: