use idl files (if any) #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
jacobperron
reviewed
Jun 5, 2019
There was a problem hiding this comment.
With the current state of ros2/test_interface_files#6, this will not build the IDL messages. To help prevent regressions, is it possible to only generate the new message for fastrtps?
Where and how should that condition be added? |
It would be nice if we could do it in the CMakeLists.txt, but I'm not sure how. If there's not a known easy way to do this then we can leave it as-is. |
jacobperron
approved these changes
Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to ros2/test_interface_files#6.