rcl_logging_interface is only valid path with build environment.

[fujitatomoya]

closes #121

[fujitatomoya]

either @clalancette or @ahcorde can you take a look?

[gergondet-woven]

Thanks for the quick response @fujitatomoya I think that would do it for #121

Could it be cherry-picked to jazzy once it's merged? Thanks!

[sloretz]

IIUC because rcl_logging_spdlog uses target_link_libraries(... PUBLIC) with a target from rcl_logging_interface it needs to export the dependency on rcl_logging_interface. The package.xml looks ok, but the call to ament_export_dependencies(rcl_logging_interface) line was removed in #102

If adding ament_export_dependencies(rcl_logging_interface) does not resolve #121 then there's likely a bug in the CMake scraping done by drake-ros/bazel_ros2_rules.

[fujitatomoya]

@gergondet-woven

I think i was misunderstanding, I am not 100% sure but I think @sloretz 's comment #122 (review) is correct. rcl_logging_spdlog needs to export the dependency on rcl_logging_interface, so putting ament_export_dependencies(rcl_logging_interface) back to see if the problem solves?

[gergondet-woven]

so putting ament_export_dependencies(rcl_logging_interface) back to see if the problem solves?

Yes, this would work as well and it's even more correct.

I have also confirmed that I had no scrapping issues in that case since the rcl_logging_interface::rcl_logging_interface is correctly imported before the rcl_logging_spdlog defines its targets.

[fujitatomoya]

@sloretz @gergondet-woven could you review one more time?

[gergondet-woven]

LGTM 👍

[ahcorde]

Pulls: #122
Gist: https://gist.githubusercontent.com/ahcorde/d01cd595cc9a1be19db5cdb3f823f200/raw/b71a04a9d35d807536727ae4a258d53cd5b6fdbb/ros2.repos
BUILD args: --packages-above-and-dependencies rcl_logging_noop rcl_logging_spdlog --packages-above-and-dependencies rcl_logging_noop rcl_logging_spdlog
TEST args: --packages-above rcl_logging_noop rcl_logging_spdlog --packages-above rcl_logging_noop rcl_logging_spdlog
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14635

• Linux
• Linux-aarch64
• Linux-rhel
• Windows

[clalancette]

@Mergifyio backport jazzy iron humble

[mergify]

backport jazzy iron humble

✅ Backports have been created

• #123 rcl_logging_interface is only valid path with build environment. (backport #122) has been created for branch jazzy
• #124 rcl_logging_interface is only valid path with build environment. (backport #122) has been created for branch iron but encountered conflicts
• #125 rcl_logging_interface is only valid path with build environment. (backport #122) has been created for branch humble but encountered conflicts